Delegate input to #[proc_macro] at Rust 1.45+ #64

taiki-e · 2020-10-25T16:28:32Z

Closes #62

taiki-e · 2020-10-25T16:41:55Z

src/lib.rs

+#[cfg_attr(not(fn_like_proc_macro), path = "fallback/mod.rs")]
+#[cfg_attr(fn_like_proc_macro, path = "compiler.rs")]
+mod imp;
+use crate::imp::*;


I had to use cfg for more than half of lib.rs and perse.rs's items, so I separated the files that have code that needs cfg.

taiki-e · 2020-10-25T20:51:18Z

This also fixes #20, #43, and #63 at Rust 1.45+.

proc-macro-hack does nothing in these versions, so proc-macro-nested doesn't need to do anything either.

dtolnay

Thanks for the PR! I think it would be problematic to automatically use a native proc_macro everywhere possible, since the hygiene can be subtly different. I opened a different implementation in #66 with an opt in attribute arg.

taiki-e commented Oct 25, 2020

View reviewed changes

This was referenced Oct 25, 2020

Consider compiling to pass-through implementation on new compilers #62

Closed

futures-macro (pulled in by futures-util) appears not to compile on musl rust-lang/futures-rs#2242

Closed

taiki-e force-pushed the fn_like_proc_macro branch from 22ae15f to d72aed9 Compare October 25, 2020 20:53

taiki-e added 3 commits October 28, 2020 07:02

Delegate input to #[proc_macro] at Rust 1.45+

de01675

Move argument parser to own module

52a4b90

Make proc-macro-nested empty crate at Rust 1.45+

1e609ab

proc-macro-hack does nothing in these versions, so proc-macro-nested doesn't need to do anything either.

taiki-e force-pushed the fn_like_proc_macro branch from d72aed9 to 1e609ab Compare October 27, 2020 22:04

dtolnay mentioned this pull request Oct 27, 2020

Add attribute to bypass proc-macro-hack and use native macro #66

Merged

dtolnay reviewed Oct 28, 2020

View reviewed changes

dtolnay closed this in #66 Oct 28, 2020

taiki-e deleted the fn_like_proc_macro branch October 28, 2020 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegate input to #[proc_macro] at Rust 1.45+ #64

Delegate input to #[proc_macro] at Rust 1.45+ #64

taiki-e commented Oct 25, 2020

taiki-e Oct 25, 2020

taiki-e commented Oct 25, 2020

dtolnay left a comment

Delegate input to #[proc_macro] at Rust 1.45+ #64

Delegate input to #[proc_macro] at Rust 1.45+ #64

Conversation

taiki-e commented Oct 25, 2020

taiki-e Oct 25, 2020

Choose a reason for hiding this comment

taiki-e commented Oct 25, 2020

dtolnay left a comment

Choose a reason for hiding this comment