Hide panic output in nightly_works #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I've been hesitant to implement this solution before due to the race with other libraries (not within It's true that this is likely gonna be fine in practice 99% of the time, but I'd personally err on the side of "100% correct, 'meh' output sometimes" rather than "99% correct, but friendly output all the time". That being said though I don't feel too too strongly on this. Could we perhaps implement some sort of sanity check to see if the hook we get back out is the same temporary one that we inserted? Maybe panic if there's a mismatch? |
|
Makes sense. I added a sanity check by comparing the pointer value before and after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122.