Fix source_text treating span.lo as byte offset not char index #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
commented
Oct 9, 2023
| @@ -364,7 +364,10 @@ impl FileInfo { | |||
|
|
|||
| fn source_text(&self, span: Span) -> String { | |||
| let lo = (span.lo - self.span.lo) as usize; | |||
| let trunc_lo = &self.source_text[lo..]; | |||
| let trunc_lo = match self.source_text.char_indices().nth(lo) { | |||
There was a problem hiding this comment.
This makes it O(n²) to compute the source_text of lots of tokens in the same stream, which is probably an important use case. I'll follow up with a separate PR to amortize this.
for token in token_stream {
let _ = token.span().source_text();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410.