Update upstream benchmark instructions #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this is the last one...
I tried running the upstream bench and couldn't because it seems the
bavel BUILD
file has been updated (I didn't look deep at how bavel works)... I've then updated bench instructions here.The only strange thing is that in both machines I've tested (linux and macOS, both intel) the upstream benchmark runs "a lot" slower than yours, but the bench itself doesn't seem to have been touched in the last two years.
Thanks a lot for your time 😄
Upstream ryu:
This repository (rust ryu):