Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream benchmark instructions #34

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update upstream benchmark instructions #34

merged 1 commit into from
Oct 2, 2020

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Oct 2, 2020

Okay, this is the last one...

I tried running the upstream bench and couldn't because it seems the bavel BUILD file has been updated (I didn't look deep at how bavel works)... I've then updated bench instructions here.

The only strange thing is that in both machines I've tested (linux and macOS, both intel) the upstream benchmark runs "a lot" slower than yours, but the bench itself doesn't seem to have been touched in the last two years.

Thanks a lot for your time 😄

Upstream ryu:

$ bazel run -c opt //ryu/benchmark:ryu_benchmark --
INFO: Analyzed target //ryu/benchmark:ryu_benchmark (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //ryu/benchmark:ryu_benchmark up-to-date:
  bazel-bin/ryu/benchmark/ryu_benchmark
INFO: Elapsed time: 0.099s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action
    Average & Stddev Ryu  Average & Stddev Grisu3
32:   37.836    1.203      127.561    1.474
64:   45.231    0.719      141.094    1.422

This repository (rust ryu):

$  cargo run --example upstream_benchmark --release
    Finished release [optimized] target(s) in 0.09s
     Running `target/release/examples/upstream_benchmark`
             Average   Stddev
pretty32:      21.008    1.530
pretty64:      28.560    1.955

@dtolnay dtolnay merged commit 9e0b62c into dtolnay:master Oct 2, 2020
@dtolnay
Copy link
Owner

dtolnay commented Oct 2, 2020

Thanks for flagging the benchmark performance difference. That is bizarre. I filed #35 to track and investigate.

@pheki pheki deleted the update-upstream-bench branch November 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants