Fix #124: ^0.11.0-rc.2 should not match 0.11.0 #166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke a few tests, but my reading of the rules is that these did not match spec:
https://docs.npmjs.com/misc/semver#tilde-ranges-123-12-1
On the other hand whether we want to make this change I don't know:
0.11.0-rc.2 < 0.11.0
— that test itself won't pass but the compatibility (^
) rule allows people to treat it almost like it is (note though that^0.11.0
will never match0.11.0-rc.2
due to restriction on prerelease tags)x.y.z-A < x.y.z
for all x/y/z/A (see my other comment)