Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non_camel_case_types in generated code #21

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Allow non_camel_case_types in generated code #21

merged 1 commit into from
Jul 27, 2023

Conversation

HartS
Copy link
Contributor

@HartS HartS commented Jul 27, 2023

Prevents warning when using the Deserialize_repr and Serialize_repr macros, as the discriminant struct created in the expanded code is all lowercase:

Structure `discriminant` should have CamelCase name, e.g. `Discriminant` rust-analyzer(non_camel_case_types)

@HartS
Allow non_camel_case_types in generated code
a35ad2e 
Prevents warning when using the Deserialize_repr and Serialize_repr
macros, as the `discriminant` struct created in the expanded code
is all lowercase:

```
Structure `discriminant` should have CamelCase name, e.g. `Discriminant` rust-analyzer(non_camel_case_types)
```
dtolnay
dtolnay approved these changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 278f7fd into dtolnay:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HartS @dtolnay