Ensure that README code example is up to date #1017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Apr 10, 2021
| @@ -306,6 +306,13 @@ extern crate unicode_xid; | |||
| #[cfg(feature = "printing")] | |||
| extern crate quote; | |||
|
|
|||
| #[cfg(doctest)] | |||
There was a problem hiding this comment.
Note that this increases MSRV to 1.40. BurntSushi/termcolor#35
There was a problem hiding this comment.
Outch, good point!
dtolnay
reviewed
Apr 10, 2021
|
Sorry, was using syn in one of my project and realized that, completely forgot I already sent the same change proposal to other project of yours. Will try to not do it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provide a simple way to check that your README example is up-to-date.