Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Punctuated::remove(index) #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/punctuated.rs
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,23 @@ impl<T, P> Punctuated<T, P> {
}
}

/// Removes and returns the punctuated pair at position `index`.
///
/// # Panics
///
/// Panics if `index` is out of bounds.
pub fn remove(&mut self, index: usize) -> Pair<T, P> {
assert!(index < self.len(), "Punctuated::remove: index out of range");

if index == self.inner.len() {
let t = self.last.take().unwrap();
Pair::End(*t)
} else {
let (t, p) = self.inner.remove(index);
Pair::Punctuated(t, p)
}
}

/// Clears the sequence of all values and punctuation, making it empty.
pub fn clear(&mut self) {
self.inner.clear();
Expand Down