-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std support on nightly #211
Conversation
a11c8cb
to
4c01863
Compare
4c01863
to
49fe623
Compare
I just rebased. @dtolnay do you have any comments on this? |
This PR has been open for quite a while, are you going to review it @dtolnay anytime soon? |
@dtolnay what would be prerequisute for merge please ? thank you a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to consider this only after it works on stable rustc.
Thanks anyway for the PR!
okey, will continue use fork. btw this pr does not required nightly on std? so other users intact, only who want no std will be nightly? |
I found this after going down the same road. Here's a version that has all tests passing on both |
As mentioned by #196, nightly now has the
error_in_core
feature. This make no_std support pretty straightforward (just replacestd
withcore
in a few places).Some tests don't work on on no_std to keep the commit small for now. Maybe this is fine until
error_in_core
is merged, because there are only 5 lines in#[cfg(not(feature = "std"))]
guards, so running the tests withstd
disabled hardly increases coverage anywayOnce
error_in_core
is in stable, even this little trick:can be removed, or not, depending on how important the MSRV guarantees are.
Thoughts?