suppress needless_lifetimes lints from clippy 0.1.83 #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I did this correctly.
In Clippy 0.1.83, without the changes in
expand.rs
, the new test intest_lints.rs
fails with the following output:Clippy doesn't like the generated
impl From
and gets confused about what it's fixing (rust-lang/rust-clippy#12789?) and the result is a confusing message suggesting code that is broken in multiple ways. TheDisplay
andError
impls don't seem to be affected, so this probably only affects users that use borrowed errors and#[from]
.I encountered this in a project I can't share, but it's the same case as ruffle-rs/ruffle#18761 https://github.com/ruffle-rs/ruffle/blob/bd89e5b216769168d08548f01e2b6871280ab829/core/src/avm1/error.rs