Cache module instantiations per-thread #21
Conversation
|
Another alternative could be: watt::instantiate_wasm!(WASM, "path/to/foo.wasm");or static WASM: watt::Instance = watt::instantiate_file!("path/to/foo.wasm"); |
There was a problem hiding this comment.
This does limit the API a bit, in that it makes it harder to dynamically instantiate modules. It's probably ok, though, as the crate has a limited intended use-case. I'd have to modify something like crts quite a bit to get it working, but we shouldn't be optimizing for that use-case anyway.
| exec::proc_macro(fun, vec![args, input], wasm) | ||
| fn id(&self) -> usize { | ||
| static NEXT_ID: AtomicUsize = AtomicUsize::new(1); | ||
| match self.id.load(SeqCst) { |
There was a problem hiding this comment.
I'm fairly confident the orderings in this method can be Relaxed, as they aren't providing any ordering guarantees for memory other than themselves.
There was a problem hiding this comment.
I personally prefer to use SeqCst everywhere unless performance becomes an issue, and I'm pretty certain performance is not an issue here.
| /// ``` | ||
| pub fn proc_macro(fun: &str, input: TokenStream, wasm: &[u8]) -> TokenStream { | ||
| exec::proc_macro(fun, vec![input], wasm) | ||
| pub struct Instance { |
There was a problem hiding this comment.
It'd probably be good to have a doc comment on the Instance struct itself, explaining that it's intended to be used in a static.
This commit continues to rejigger the API of `watt` by having a top-level `Instance` type now instead of a suite of top-level functions. By using a top-level `struct` we can store an internal identifier (`usize`) which is used to key a thread-local cache for wasm blobs. This should allow us to share resources like module instantiations across macro invocations, ensuring that we only instantiate modules once-per-process. Closes dtolnay#16
This commit continues to rejigger the API of
wattby having atop-level
Instancetype now instead of a suite of top-level functions.By using a top-level
structwe can store an internal identifier(
usize) which is used to key a thread-local cache for wasm blobs. Thisshould allow us to share resources like module instantiations across
macro invocations, ensuring that we only instantiate modules
once-per-process.
Closes #16