Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(1) updated dashboard component to enforce minWidth settings. (2) upd… #182

Merged
merged 6 commits into from
May 6, 2017
Merged

(1) updated dashboard component to enforce minWidth settings. (2) upd… #182

merged 6 commits into from
May 6, 2017

Conversation

wvary
Copy link
Contributor

@wvary wvary commented Sep 8, 2016

…ated dashboard component to apply width/minWidth on browser resize. (3) Refactored GrabSizer to support horizontal and vertical resizing. (4) added CartDataModel to be used in dynamic data examples. (5) added examples to demonstrate refreshing widgets with dynamic options. (6) added examples to demonstrate refreshing widgets with dynamic data. (7) added resize examples to demonstrate with minWidth support. (8) added coverage report to test. (9) added/updated unit tests for complete code coverage.

Resolve issue #140 (demonstrated by item 7)
Resolve issue #137 (demonstrated by item 6)
Resolve issue #136 (demonstrated by item 5)
Resolve issue #126 (demonstrated by item 6)

This was referenced Jan 4, 2017
Closed
Closed
@wvary
Copy link
Contributor Author

wvary commented Feb 16, 2017

@mohini-sri90 Please review PR when you have a chance, thanks.

@wvary wvary force-pushed the resolve_issues_126_136_137_140.SPOI-7882 branch from 0600854 to c49a4e5 Compare April 5, 2017 18:59
@wvary wvary force-pushed the resolve_issues_126_136_137_140.SPOI-7882 branch from c49a4e5 to d5b6b1e Compare April 17, 2017 20:11
1. Updated dashboard component to enforce minWidth settings.
23d9060 
2. Updated dashboard component to apply width/minWidth on browser resize
3. Refactored GrabSizer to support horizontal and vertical resizing
4. Added CartDataModel to be used in dynamic data examples
5. Added examples to demonstrate refreshing widgets with dynamic options
6. Added examples to demonstrate refreshing widgets with dynamic data
7. Added resize examples to demonstrate with minWidth support
8. Added coverage report to test
9. Added/updated unit tests for complete code coverage
10.Set karma package to 0.13.22
@wvary wvary force-pushed the resolve_issues_126_136_137_140.SPOI-7882 branch from d5b6b1e to 23d9060 Compare April 18, 2017 01:13
@sashadt sashadt assigned sashadt and unassigned jessicawangdt May 2, 2017
@sashadt
Copy link
Contributor

sashadt commented May 2, 2017

A few review comments:

  1. When title doesn't fit the widget width, we should not let controls (on top right) overflow to the next level. They should always stay in the top right corner. Title text should be abbreviated by "..." ellipsis.

  2. Slight delay (3-4 sec) when widget of fixed percentage width is resized due to browser window size changes.

  3. [Optional] Improve behavior when resizing past the minimum width limit. Do not let the outline go past minimum width.

  4. [New Feature] Resizing from corner is not possible today - would make things much easier if X and Y dimensions could be resized at the same time.

  5. Could be useful to have min height in addition to min width.

@wvary
Copy link
Contributor Author

wvary commented May 3, 2017

Regarding point #2, it's by design. The widget option set in the application sets a delay of 2 seconds to demonstrates such feature.

@sashadt
Copy link
Contributor

sashadt commented May 3, 2017

Let's remove the delay from the demo.

Willet Vary added 2 commits May 4, 2017 16:42
1. Updated test code to have zero delay on windows resize.
e1d1ff5 
2. Prevented resize marquee from drawing smaller than min with and min height settings
3. Added support to resize using all borders and border corners
1. Updated code to be more backward compatible:
4a5e372 
   a. Changed resizers from left/right/top/bottom to w/e/n/s.
   b. Changed changed widget header layout to be similar to older format.
@wvary
Copy link
Contributor Author

wvary commented May 5, 2017

@sashadt This is ready for another round of review.

@sashadt sashadt merged commit 8641bda into dtpublic:master May 6, 2017
peyao added a commit to peyao/malhar-angular-dashboard that referenced this pull request Apr 21, 2018
@peyao
Merge latest changes from DataTorrent. (#1)
86fdd02 
* Resolved dtpublic#144 : Fixed several invalid urls in the README.md file

* SPOI-9924 #resolve : Hide input box upon focus lost

1. Updated code to hide the input box when focus is lost.
2. Added code to prevent page refresh when user presses the Enter key in the input box (this only happen once for every new browser open).

The two issues above apply to dashboard layout title and widget title editing.

* Added circle.yml

* Added Dockerfile. Error exists.

* Fixed most of Dockerfile

* Revert "SPOI-9924 #resolve : Hide input box upon focus lost"

* SPOI-9924 #resolve : Hide input box on focus lost (dtpublic#190)

* SPOI-9924 #resolve : Hide Input Box On Focus Lost When Editing Tab Title

* Set angular-sanitize to 1.5.8 to fix build error

* Updated patch version

* Prevent saving empty title

* 1. Added new prependWidget function to dashboard and layout to allow users to insert a new widget to beginning of dashboard
2. Added links to all pages to demonstrate the prependWidget function
3. Updated unit tests

* (1) updated dashboard component to enforce minWidth settings. (2) upd… (dtpublic#182)

* 1. Updated dashboard component to enforce minWidth settings.
2. Updated dashboard component to apply width/minWidth on browser resize
3. Refactored GrabSizer to support horizontal and vertical resizing
4. Added CartDataModel to be used in dynamic data examples
5. Added examples to demonstrate refreshing widgets with dynamic options
6. Added examples to demonstrate refreshing widgets with dynamic data
7. Added resize examples to demonstrate with minWidth support
8. Added coverage report to test
9. Added/updated unit tests for complete code coverage
10.Set karma package to 0.13.22

* Fixed dynamic options: when clicking top thumbmail button, view wasn't rendering thumbnail view.

* Fixed unit test

* Updated widget header to show ellipsis if title is too long

* 1. Updated test code to have zero delay on windows resize.
2. Prevented resize marquee from drawing smaller than min with and min height settings
3. Added support to resize using all borders and border corners

* 1. Updated code to be more backward compatible:
   a. Changed resizers from left/right/top/bottom to w/e/n/s.
   b. Changed changed widget header layout to be similar to older format.

* SPOI-11522 #resolve : Support fixed height to width ratio option (dtpublic#196)

* 1. Changed marquee z-index to 999999
2. Set widget default margin right to 0
3. Restrict marquee to stop as min width/height and max width if applicable/set
4. Added support for fixed height to width ratio option

* ran build

* 1. Fixed bug to only set width/height if user actually change the marquee width and height
2. Don't run applyMinHeight on widget added event
   This was causing the widget min height to be set because of a race condition

* Don't run resize event with width or height is zero (dtpublic#197)

* Don't run resize event with width or height is zero

* Run applyMinHeight on widgetAdded event

* Save returns value of setItem, allows setItem to return promises (dtpublic#201)

* Save returns value of setItem, allows setItem to return promises

* Include missing line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wvary @sashadt @mohini-sri90 @jessicawangdt