-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable lint checks #1079
Re-enable lint checks #1079
Conversation
Concept ACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for reenabling the checks. ConceptACK.
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConceptACK ae52550
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 9b279c1
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
A linting step failed, probably due to rebase with #1080 Had this pull request been merged before mine I'd have had to justfiy introducing a boost dependency, so let me speak here ;-) This is a dependency which is only introduced in tests + we do not have any intention to move away from the boost unit tests. While in general the idea is to migrate boost-features to equivalent C++ native features (like favor So I guess it should be added to the known boost dependencies. |
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 128f7a9
This PR tries to fix and re-enable the lint checks that were disabled for the 0.17 merge. Enabled checks:
The last several checks require extensive code changes, so I'd like to submit them in separate PRs.
Part of #1054.