Fix p2p_segwit.py test #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scravy
previously approved these changes
Mar 18, 2019
castarco
approved these changes
Mar 18, 2019
Ruteri
approved these changes
Mar 18, 2019
scravy
reviewed
Mar 18, 2019
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
scravy
approved these changes
Mar 18, 2019
Signed-off-by: Matteo Sumberaz <matteo@thirdhash.com>
|
utACK 1ac84d0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is tail update in
additional_bytes, ifadditional_bytes % 55 = 0, it will not add the +1 byte needed to passassert_equal(vsize, MAX_BLOCK_BASE_SIZE + 1).The algorithm needs to do one last pass, that will happen if
additional_bytes % 55 = 0, where it will addmin(0+1, 55)extra_bytes. Ifadditional_bytes % 55 > 0, after the updateadditional_byteswill be < 0 and skip the last pass.This has been discovered because the coinbase scriptSig changed from 71 to 72 bytes (due to changed coinbase reward in #794), causing the total block size to be % 55 with no remainder.