New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposer finalization rewards #811

Closed

Nizametdinov wants to merge 48 commits into dtr-org:master from Nizametdinov:proposer-finalization-rewards

Member

Nizametdinov commented Mar 20, 2019 •

edited

Loading

This pull request implements proposer finalization rewards. See the details in #418.

thothd requested a review from Gnappuraz

March 20, 2019 13:05

Nizametdinov force-pushed the proposer-finalization-rewards branch from 4234aa7 to 12e6701 Compare

March 20, 2019 13:06

thothd added finalization proposing economics labels

Nizametdinov force-pushed the proposer-finalization-rewards branch 2 times, most recently from afdd628 to 03fc85b Compare

March 27, 2019 20:34

Nizametdinov force-pushed the proposer-finalization-rewards branch 2 times, most recently from e63cdd4 to 74f0e3b Compare

April 2, 2019 14:24

Nizametdinov mentioned this pull request

Coinbase with just one output fails for the wrong reason #777

Closed

scravy reviewed

View reviewed changes

src/proposer/block_builder.cpp Outdated Show resolved Hide resolved

Nizametdinov force-pushed the proposer-finalization-rewards branch from 4d9830d to a4ea67d Compare

April 8, 2019 10:03

Nizametdinov marked this pull request as ready for review

April 8, 2019 10:06

Nizametdinov force-pushed the proposer-finalization-rewards branch from 5555806 to 4a18cb4 Compare

April 8, 2019 10:24

Nizametdinov requested a review from a team

April 8, 2019 11:34

Ruteri reviewed

View reviewed changes

src/consensus/tx_verify.cpp Outdated Show resolved Hide resolved

src/proposer/finalization_reward_logic.cpp Outdated Show resolved Hide resolved

src/test/tx_verify_tests.cpp Show resolved Hide resolved

test/functional/feature_finalization_rewards.py Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/consensus/tx_verify.cpp Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.h Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.cpp Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.cpp Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.cpp Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.h Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/proposer/finalization_reward_logic.h Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/injector.h Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/injector.h Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/test/blockchain/blockchain_parameters_tests.cpp Outdated Show resolved Hide resolved

scravy reviewed

View reviewed changes

src/test/proposer/finalization_reward_logic_tests.cpp Outdated Show resolved Hide resolved

Nizametdinov force-pushed the proposer-finalization-rewards branch 3 times, most recently from 9e3eb22 to 2f74883 Compare

April 10, 2019 08:49

Nizametdinov added 23 commits

April 11, 2019 10:19


          Adjust feature_finalization_rewards

7c6d765

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Check finalization reward maturity when choosing stakeable coins

c7e62fb

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Check finalization reward maturity in wallet

623f845

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix formatting

6e63753

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix p2p_unrequested_blocks

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix interface_rest

42c300d

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix segfault in WalletExtension::ForEachStakeableCoin

b548063

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix wallet_txn_clone and maturity checks in wallet

4b861e6

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix feature_spend_genesis

ebb27a6

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix feature_ltor

207037d

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix feature_csv_activation

c866fab

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix feature_assumevalid

4f6230e

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix p2p_compactblocks

cfe90b3

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix feature_versionbits_warning

5c71f9e

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Address review comments

d38708c

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix typo

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Address more review comments

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Finalization reward validation after ISD

97fbc99

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Move finalization_reward_logic.cpp from wallet to core

5189c36

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix number of coinbase outputs check in Consensus::CheckBlockRewards

7d2c689

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Address review comments

e8e5b3e

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Fix formatting

bbd2af8

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>


          Enable finalization in example_test

022ac5c

Remove unused import in feature_ltor

Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>

Nizametdinov force-pushed the proposer-finalization-rewards branch from b22997c to 022ac5c Compare

April 11, 2019 08:38

thothd added this to the 0.2 milestone

cmihai mentioned this pull request

Fix coinbase transaction amount returned by filtertransactions #971

Merged

cmihai added a commit that referenced this pull request


          Fix coinbase transaction amount returned by filtertransactions (#971)

c8d807d

This commit cherry-picks the GetAmount changes from #811 and fixes the filtertransactions RPC output for coinbase transactions, setting the "fee" field to zero and "amount" to the reward received by the miner. Previously, as a side-effect of the algorithm, it was the other way around.

Signed-off-by: Mihai Ciumeica <mihai@thirdhash.com>

Member

scravy commented May 6, 2019

I guess this needs rebase.

Maybe it would make sense, since this has already accumulated quite a lot of comments, is quite out of date, etc, and needs heavy rebasing/merging as 0.17 was merged in between – maybe it would make sense to create a fresh pull request and start with a clean slate?

Member Author

Nizametdinov commented May 6, 2019

@scravy I'm going to open a new PR also because my old fork is now detached from the upstream. I'm closing this one and will open a new one soon.

Nizametdinov closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ruteri Ruteri left review comments

frolosofsky frolosofsky left review comments

Gnappuraz Gnappuraz left review comments

kostyantyn kostyantyn left review comments

scravy scravy left review comments

thothd thothd requested changes

Labels

economics finalization proposing