Add getrawsnapshot RPC #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functional tests we use p2p interface to retrieve the snapshot before broadcasting to other nodes. It works fine but now we want to extend tests and broadcast the valid snapshot but which is not part of finalized epoch. The issue is that from p2p we can't receive the non-finalized snapshot to simulate this scenario. Having an RPC command to retrieve any available snapshot will help us to extend fast sync tests. Signed-off-by: Kostiantyn Stepaniuk <kostia@thirdhash.com>
Gnappuraz
approved these changes
Apr 2, 2019
scravy
reviewed
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In functional tests we use p2p interface to retrieve the snapshot
before broadcasting to other nodes. It works fine but now we want to
extend tests and broadcast the valid snapshot but which is not
part of the finalized epoch. The issue is that from p2p we can't
receive the non-finalized snapshot to simulate this scenario
and it's needed in the #852
Having an RPC command to retrieve any available snapshot
will help us to test the sync after we introduced commits
Signed-off-by: Kostiantyn Stepaniuk kostia@thirdhash.com