Cinema 4D Cast Support #60

Devostated · 2024-04-12T12:58:44Z

Cast Model support for Cinema 4D.

Supports:

Meshes
Skeleton
Materials
UVs
Weights
Vertex colors
Constraints
IK handles

Installation:
Create a folder with the name "Cast", "io_scene_cast" or any other suitable name and place the files in there. The cast python library (cast.py) should be placed in the resource folder named "res" in the plugins directory.

Requirements:
Cinema 4D 2024 or newer

Currently not supported:

Animations
Instances
Blend shapes

Cast Model support for Cinema 4D. Supports: - Meshes - Skeleton - Materials - Vertex colors - Constraints - IK handles Installation: Create a folder with the name "Cast", "io_scene_cast" or any other suitable name and place the files in there. The cast python library (cast.py) should be placed in the resource folder named "res" in the plugins directory. Requirements: Cinema 4D 2024 or newer Currently not supported: - Animations - Instances - Blend shapes

dtzxporter · 2024-04-12T13:50:35Z

Will review this weekend

Devostated · 2024-04-12T17:11:10Z

Might add instances if I find time tomorrow

dtzxporter

Left some comments, nothing extremely major, just code cleanup and using enums instead of raw values for clarity.

plugins/cinema4d/import_cast.pyp

dtzxporter · 2024-04-12T18:43:40Z

plugins/cinema4d/import_cast.pyp

+from c4d import plugins, bitmaps, Vector, gui, BaseObject
+import mxutils
+
+resDir = os.path.join(os.path.dirname(__file__), "res")


Prefer global constants as all caps:

RESOURCE_DIR

dtzxporter · 2024-04-12T18:48:31Z

plugins/cinema4d/import_cast.pyp

+            skinningMethod = mesh.SkinningMethod()
+            skinType = c4d.ID_CA_SKIN_OBJECT_TYPE
+            if skinningMethod == "linear":
+                skinObj[skinType] = 0


Use the enum value:

Linear (c4d.ID_CA_SKIN_OBJECT_TYPE_LINEAR) Spherical (c4d.ID_CA_SKIN_OBJECT_TYPE_QUAT) Blended (c4d.ID_CA_SKIN_OBJECT_TYPE_BLENDED)

Some of the enum stuff came through just looking into Cinema 4Ds Script log and console.
Where it just spits out the index as an example from the script log object()[c4d.ID_BASEOBJECT_ROTATION_ORDER] = 5, same was for bools and I just took that with me without thinking too much about it.
Will change it for sure!

dtzxporter · 2024-04-12T18:48:37Z

plugins/cinema4d/import_cast.pyp

+            if skinningMethod == "linear":
+                skinObj[skinType] = 0
+            elif skinningMethod == "quaternion":
+                skinObj[skinType] = 1


Same as above.

dtzxporter · 2024-04-12T18:49:04Z

plugins/cinema4d/import_cast.pyp

+        if model.Skeleton() is not None and node[CAST_IMPORT_BIND_SKIN]:
+            skinObj = BaseObject(c4d.Oskin)
+            skinningMethod = mesh.SkinningMethod()
+            skinType = c4d.ID_CA_SKIN_OBJECT_TYPE


It's probably fine to just inline this, no need for an extra line.

I'm not quiet sure what you mean.
Like that?

- skinType = c4d.ID_CA_SKIN_OBJECT_TYPE if skinningMethod == "linear": - skinObj[skinType] = 0 + skinObj[c4d.ID_CA_SKIN_OBJECT_TYPE] = c4d.ID_CA_SKIN_OBJECT_TYPE_LINEAR elif skinningMethod == "quaternion": - skinObj[skinType] = 1 + skinObj[c4d.ID_CA_SKIN_OBJECT_TYPE] = c4d.ID_CA_SKIN_OBJECT_TYPE_QUAT

dtzxporter · 2024-04-12T18:54:55Z

plugins/cinema4d/import_cast.pyp

+        handles[i] = newBone
+        boneIndexes[bone.Hash() or i] = newBone
+
+        if bone.ParentIndex() > -1:


The bone order is not guaranteed that the parents come first. You should enumerate twice in order to set the parents after all bones are created to prevent issues.

plugins/cinema4d/import_cast.pyp

dtzxporter · 2024-04-12T18:56:10Z

plugins/cinema4d/import_cast.pyp

+            material = materialArray[meshMaterial.Name()]
+            material_tag = newMesh.MakeTag(c4d.Ttexture)
+            material_tag[c4d.TEXTURETAG_MATERIAL] = material
+            material_tag[c4d.TEXTURETAG_PROJECTION] = 6


Use the enum value:

Spherical (c4d.TEXTURETAG_PROJECTION_SPHERICAL) Cylindrical (c4d.TEXTURETAG_PROJECTION_CYLINDRICAL) Flat (c4d.TEXTURETAG_PROJECTION_FLAT) Cubic (c4d.TEXTURETAG_PROJECTION_CUBIC) Frontal (c4d.TEXTURETAG_PROJECTION_FRONTAL) Spatial (c4d.TEXTURETAG_PROJECTION_SPATIAL) UVW Mapping (c4d.TEXTURETAG_PROJECTION_UVW) Shrink Wrapping (c4d.TEXTURETAG_PROJECTION_SHRINKWRAP) Camera Mapping (c4d.TEXTURETAG_PROJECTION_CAMERAMAP)

dtzxporter · 2024-04-12T19:00:03Z

plugins/cinema4d/import_cast.pyp

+                normalList.insert((i + 1) * 4 - 1, Vector(0, 0, 0))
+
+            # Maps data from float to int16 value
+            normalListToSet = [int(component * 32000.0)


This doesn't seem like the right logic.

Can you explain this further? Got the idea from an older official python example:

https://github.com/PluginCafe/cinema4d_py_sdk_extended/blob/16990bb52bcfbf2cea5b66eacb685c64845859a2/scripts/04_3d_concepts/modeling/read_write_normal_tag_r13.py#L10C7-L12C34

https://github.com/PluginCafe/cinema4d_py_sdk_extended/blob/16990bb52bcfbf2cea5b66eacb685c64845859a2/scripts/04_3d_concepts/modeling/read_write_normal_tag_r13.py#L93

Nice! I would include the snippet in the first link as a comment to explain this, because the 32000 is extremely arbitrary! It explains it better than 'float to int16'.

dtzxporter · 2024-04-12T19:02:12Z

plugins/cinema4d/import_cast.pyp

+We are using Blender unpack_list for convinience
+https://github.com/blender/blender/blob/main/scripts/modules/bpy_extras/io_utils.py#L370
+"""
+def unpack_list(list_of_tuples):


In most instances I've seen you use this, it's completely unnecessary where you can just iterate over the pairs directly instead of slicing an unpacked list.

You should be able to remove those steps.

In the beginning I tried to replicate the Blender addon as much as possible to understand the whole process better, that's how this happened. Will remove them!

Devostated · 2024-04-12T19:10:59Z

Thanks for all the feedback, helps a lot! I'll get on it tomorrow.

- usage of enums - added comments - usage of bools - parenting bones in an extra loop - minor cleanup Missing: - pole dtzxporter#60 (comment) - usage of c4d.quaternion() dtzxporter#60 (comment) - removing unpack_list steps dtzxporter#60 (comment)

dtzxporter · 2024-05-19T20:54:52Z

@Devostated am I waiting for more or is this ready for review again?

Devostated · 2024-05-20T15:43:15Z

Sorry for no updates. I'm kinda lost in exams right now. I would do the pole bones in one or two days.
I'm not too familiar with the poles. Can you give me any recommendations for a setup?
Here are the available settings:

dtzxporter · 2024-05-20T16:12:26Z

"Pole vector object" should be pole vector bone.

"Pole vector twist" should be keyed to the rotation x value of pole vector.

New Feature: - Instance import Improvements: - using c4d.Quaternion() - using PoleVectorBone instead of PoleBone Requirements: - Cinema 4D 2024.5 or newer

Devostated · 2024-08-12T18:50:42Z

Animation support will come in around October, when my uni projects are done. In the mean time please let me know if you see anything that would need improving.

dtzxporter

Just a few minor nits, nothing major. Coming along nicely!

plugins/cinema4d/import_cast.pyp

dtzxporter · 2024-08-17T04:45:07Z

plugins/cinema4d/import_cast.pyp

@@ -173,6 +177,7 @@ def importModelNode(doc, node, model, path):
        for i in range(mesh.UVLayerCount()):
            uvTag = c4d.UVWTag(facesCount)
            uvBuffer = mesh.VertexUVLayerBuffer(0)
+
            uvUnpacked = unpack_list([(uvBuffer[x * 2], 1.0 - uvBuffer[(x * 2) + 1]) for x in faces])


Can we get rid of unpack_list? It should not be needed.

I had some big issues as I tried to remove it, but I'll get back to it and try again.
Here are the results I had in my tries:

dtzxporter · 2024-08-17T04:46:23Z

plugins/cinema4d/import_cast.pyp


+        poleBone = handle.PoleBone()
+        if poleBone is not None:


if handle.PoleBone():

It definitely makes more sense, I just tried to copy your plugins to have it easier to maintain. Your Blender and Maya addon use the

poleBone = handle.PoleBone() if poleBone is not None:

but I'll remove it!

I think it looks a bit better with the poleBone.Name() in the warning in my opinion.

plugins/cinema4d/import_cast.pyp

dtzxporter · 2024-08-17T04:49:39Z

plugins/cinema4d/import_cast.pyp

+                    modelNull = importModelNode(doc, node, child, instancePath)
+            modelNull.InsertUnder(sceneNull)
+        except:
+            print("Failed to import instance: %s" % instancePath)


Is there a better way to notify the user? Does this popup anywhere? See Maya/Blender reporting.

This will print in the Cinema 4D console. I could make a popup saying that something went wrong and to check console for the detailed list of what models failed.

plugins/cinema4d/import_cast.pyp

plugins/cinema4d/res/c4d_symbols.h

dtzxporter · 2024-08-19T17:43:01Z

plugins/cinema4d/import_cast.pyp

@@ -173,6 +177,7 @@ def importModelNode(doc, node, model, path):
        for i in range(mesh.UVLayerCount()):
            uvTag = c4d.UVWTag(facesCount)
            uvBuffer = mesh.VertexUVLayerBuffer(0)


I just noticed you're not importing the correct layer, you're using layer 0 for every UV layer atm!

mesh.VertexUVLayerBuffer(i)

Oh yeah, that's something I forgot to change for testing.
Cinema 4Ds materials always use the latest added UVW tag, so some models I tested had wrong UVs then and I couldn't work on materials.
Thanks for letting me know!

- usage of enums - added comments - usage of bools - parenting bones in an extra loop - minor cleanup Missing: - pole #60 (comment) - usage of c4d.quaternion() #60 (comment) - removing unpack_list steps #60 (comment)

fixed naming scheme

93f2a75

Devostated force-pushed the master branch from 8900f99 to 93f2a75 Compare April 12, 2024 13:54

dtzxporter reviewed Apr 12, 2024

View reviewed changes

Cast Model import update

4fda4f0

- usage of enums - added comments - usage of bools - parenting bones in an extra loop - minor cleanup Missing: - pole dtzxporter#60 (comment) - usage of c4d.quaternion() dtzxporter#60 (comment) - removing unpack_list steps dtzxporter#60 (comment)

dtzxporter added the enhancement New feature or request label May 21, 2024

Devostated added 4 commits July 20, 2024 15:47

Merge branch 'dtzxporter:master' into master

1d97225

Merge branch 'dtzxporter:master' into master

9543966

Merge branch 'dtzxporter:master' into master

71f57ae

Cinema 4D Cast Instances Support

d6e869d

New Feature: - Instance import Improvements: - using c4d.Quaternion() - using PoleVectorBone instead of PoleBone Requirements: - Cinema 4D 2024.5 or newer

dtzxporter requested changes Aug 17, 2024

View reviewed changes

dtzxporter requested changes Aug 19, 2024

View reviewed changes

Merge branch 'dtzxporter:master' into master

76bfc63

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cinema 4D Cast Support #60

Cinema 4D Cast Support #60

Devostated commented Apr 12, 2024

dtzxporter commented Apr 12, 2024

Devostated commented Apr 12, 2024

dtzxporter left a comment

dtzxporter Apr 12, 2024

dtzxporter Apr 12, 2024

Devostated Apr 12, 2024 •

edited

Loading

dtzxporter Apr 12, 2024

dtzxporter Apr 12, 2024

Devostated Apr 13, 2024

dtzxporter Apr 13, 2024

dtzxporter Apr 12, 2024

dtzxporter Apr 12, 2024

dtzxporter Apr 12, 2024

Devostated Apr 12, 2024

dtzxporter Apr 12, 2024

dtzxporter Apr 12, 2024

Devostated Apr 12, 2024 •

edited

Loading

Devostated commented Apr 12, 2024

dtzxporter commented May 19, 2024

Devostated commented May 20, 2024

dtzxporter commented May 20, 2024

Devostated commented Aug 12, 2024

dtzxporter left a comment

dtzxporter Aug 17, 2024

Devostated Aug 17, 2024

dtzxporter Aug 17, 2024

Devostated Aug 17, 2024

Devostated Aug 17, 2024

dtzxporter Aug 17, 2024

Devostated Aug 17, 2024

dtzxporter Aug 19, 2024

Devostated Aug 19, 2024

Cinema 4D Cast Support #60

Are you sure you want to change the base?

Cinema 4D Cast Support #60

Conversation

Devostated commented Apr 12, 2024

dtzxporter commented Apr 12, 2024

Devostated commented Apr 12, 2024

dtzxporter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Devostated Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Devostated Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

Devostated commented Apr 12, 2024

dtzxporter commented May 19, 2024

Devostated commented May 20, 2024

dtzxporter commented May 20, 2024

Devostated commented Aug 12, 2024

dtzxporter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Devostated Apr 12, 2024 •

edited

Loading

Devostated Apr 12, 2024 •

edited

Loading