fix: fix accidental mutation of stateful arrays

duality-labs · May 24, 2024 · a36b8c1 · a36b8c1
1 parent 1648ee8
commit a36b8c1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/lib/web3/utils/events.ts b/src/lib/web3/utils/events.ts
@@ -275,6 +275,7 @@ export function getLastPrice(
   { tokenA, tokenB }: { tokenA: Token; tokenB: Token }
 ) {
   const lastTickUpdate = events
+    .slice()
     .reverse()
     .find((event): event is DexTickUpdateEvent => {
       return (

diff --git a/src/pages/Orderbook/OrderbookChart.tsx b/src/pages/Orderbook/OrderbookChart.tsx
@@ -433,7 +433,7 @@ export default function OrderBookChart({
                 const resolutionInMs = resolutionInMsMap[resolution];
                 // note: the data needs to be in chronological order
                 // and our API delivers results in reverse-chronological order
-                const chronologicalUpdates = dataUpdates.reverse();
+                const chronologicalUpdates = dataUpdates.slice().reverse();
                 for (const row of chronologicalUpdates) {
                   const bar = getBarFromTimeSeriesRow(row);
                   // add extra empty bars if there would be a gap in time

diff --git a/src/pages/Orderbook/OrderbookList.tsx b/src/pages/Orderbook/OrderbookList.tsx
@@ -232,7 +232,6 @@ export default function OrderBookList({
           // add token B bucket offsets
           ...filteredBucketsB
             .filter((bucket): bucket is Bucket => !!bucket)
-            .reverse()
             .map(
               ([innerBound, outerBound], index): [PriceOffset, PriceOffset] => [
                 [innerBound, topCenterOffset - index * tableRowHeight],
@@ -306,7 +305,7 @@ export default function OrderBookList({
           </tr>
         </tbody>
         <tbody className="orderbook-list__table__ticks-top">
-          {filteredBucketsB?.reverse().map((bucket, index) => {
+          {[...filteredBucketsB].reverse().map((bucket, index) => {
             const [minPrice, price, reserves] = bucket || [];
             const lastBucket = bucketsB?.at(-1);
             return minPrice && price && reserves && lastBucket ? (