-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get token pairs list from indexer #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow single and dual data set accumulation classes
- and not mutating Class state (as a minor concern to interfacing)
- includes sample use
- for easy cancellation
- they are small and not that helpful, they are just URL creators
- it gets too complicated - these hooks should not be used for the purpose of queries where we expect the request to end. that is much better suited to the fetchDataFromIndexer abstraction (which can be used in a hook like useQuery or useSWR if desired)
dib542
force-pushed
the
451-get-tokenpairs-list-from-indexer
branch
from
November 21, 2023 14:10
25823b3
to
ff88ea1
Compare
- ID can just be the key, it doesn't need to be data - it is easy to put the ID back into an array with Array.from(map)
dib542
force-pushed
the
451-get-tokenpairs-list-from-indexer
branch
from
November 23, 2023 05:19
9a6fbd2
to
ea1e9a2
Compare
dib542
force-pushed
the
451-get-tokenpairs-list-from-indexer
branch
from
November 23, 2023 09:58
ea1e9a2
to
d776ecb
Compare
dib542
pushed a commit
that referenced
this pull request
Nov 25, 2023
## [0.3.35](v0.3.34...v0.3.35) (2023-11-25) ### Features * get token pairs list from indexer ([#476](#476)) ([59d2e0e](59d2e0e))
🎉 This PR is included in version 0.3.35 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new token pairs list from:
and the real-time SSE update mechanism from
This PR allows the token pairs list to be taken from the
/liquidity/pairs
endpoint of the indexer, instead of being derived from iterating through all existing ticks of the/cosmos/bank/v1beta1/supply
of the LCD API (which will not be feasible in production, and is not possible after the backend change: duality-labs/duality#456 which is part of v0.4.1 of the Duality chain)