Assign ID for poolDenom #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcompagni10
force-pushed
the
LP_denom_fix
branch
from
0a9c9ac to
d7ddea2
Compare
added 15 commits
September 13, 2023 16:32
jcompagni10
commented
Sep 13, 2023
| @@ -6,6 +6,7 @@ import "gogoproto/gogo.proto"; | |||
| import "duality/dex/pool_reserves.proto"; | |||
|
|
|||
| message Pool { | |||
There was a problem hiding this comment.
Add comment that this is not stored in DB
| } | ||
|
|
||
| // GetPoolMetadataIDBytes returns the byte representation of the ID | ||
| func GetPoolMetadataIDBytes(id uint64) []byte { |
jcompagni10
force-pushed
the
LP_denom_fix
branch
from
feac5a1 to
43cc141
Compare
NicholasDotSol
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated PoolMetadata storage
Add associated lookups and refs