Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Orderbook UI and buy/sell orders #539

Merged
merged 35 commits into from
Apr 9, 2024
Merged

feat: improve Orderbook UI and buy/sell orders #539

merged 35 commits into from
Apr 9, 2024

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Mar 13, 2024 •
edited
Loading

This PR cleans up parts of the Buy/Sell card of the Orderbook UI

  • adds Order Type help: link to docs
  • changes the layout of token pair prices to read eg: price 10 of pair ATOM/USDC can be read as 10USDC per ATOM
    • this shifts the order of many token pairs
  • fix loading states and warning/error display
    • reverts some of the workarounds of using Immediate or Cancel simulations to avoid the Swap amount too small errors. Now it should display these errors
  • fix SelectInput closing behavior

And is based on the previous work in the PRs

Preview:
localhost_5173_orderbook_USDC_NTRN(FullHD) (4)

@dib542 dib542 linked an issue Mar 13, 2024 that may be closed by this pull request
Improve Buy Limit Orders #459
Closed
@dib542 dib542 force-pushed the 459-improve-buy-limit-orders-part-3 branch from b96b82f to e0c22e9 Compare March 14, 2024 15:10
@github-actions GitHub Actions
Copy link

Deploy Previews

Testnet

Preview URL: https://e0c22e90-d7087c85--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65f3150375b329ed23b180f5

Beta

Preview URL: https://e0c22e90-d7087c85--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/65f31550a7ffb3eccfc2f61f

@dib542 dib542 force-pushed the 459-improve-buy-limit-orders-part-3 branch 2 times, most recently from 397044a to 4872f87 Compare April 7, 2024 20:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

Deploy Previews

Testnet

Preview URL: https://4872f871-ae7ed2c8--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6612fea9825107fc7302e6b4

Beta

Preview URL: https://4872f871-ae7ed2c8--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6612fef3dfac42fe43cf4fc6

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Deploy Previews

Testnet

Preview URL: https://bd6f5eed-d1442067--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6613c9fdbdfc6f89beba0258

Beta

Preview URL: https://bd6f5eed-d1442067--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6613ca48daf78d8920a23f76

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy Previews

Testnet

Preview URL: https://5e0ff50f-d139c3e4--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6614b00cde6f265028be1849

Beta

Preview URL: https://5e0ff50f-d139c3e4--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6614b056cc32ff4b02e20912

dib542 added 17 commits April 9, 2024 20:21
@dib542
#537
1224b3c
@dib542
#541
babeb92
@dib542
feat: add Order Type help: link to docs
42ad114
@dib542
feat: switch pool token order when displaying a pair: tokenB/tokenA
c5eddc3
@dib542
refactor: remove possibility of misaligning order type text values
ff81eb5
@dib542
refactor: read swap amout out from result payload instead of events
abad4a3
@dib542
feat: add other types of limit orders to be used in inputs
29cedf4
@dib542
fix: add negative limit price check
c87f228
@dib542
fix: price directions are dependent on buy mode and token order
ca6233a
@dib542
feat: allow indexer stream hooks to include metadata like height
5ca0d78
@dib542
fix: update simulated place limit order on each liquidity movement
05f8eae
@dib542
fix: improve loading states during continuous limit order simulations
a2c3a50
@dib542
fix: calculate approx non-immediate limit order coin out for previews
0902655
@dib542
Revert "fix: reduce FILL_OR_KILL bugs in simulations temporarily"
e94af7d 
This reverts commit cb8e7ea.
@dib542
fix: display insufficient liquidity only when the error is encountered
7c2274b
@dib542
feat: improve loading state keeping previous preview results
6dd0796
@dib542
fix: correct the range slider input in buy mode for token out
0e32ace
@dib542 dib542 force-pushed the 459-improve-buy-limit-orders-part-3 branch from 5e0ff50 to da793c3 Compare April 9, 2024 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy Previews

Testnet

Preview URL: https://6bafd3a0-c2fb53d2--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66152bef3fda61b480e53525

Beta

Preview URL: https://6bafd3a0-c2fb53d2--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66152c3afb4241060a3004fc

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy Previews

Testnet

Preview URL: https://eeca9d7c-96a07a9b--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66155da53b85620c3bdfd4ef

Beta

Preview URL: https://eeca9d7c-96a07a9b--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66155deee42d7209d0d86cc6

@dib542 dib542 force-pushed the 459-improve-buy-limit-orders-part-3 branch from eeca9d7 to 67776af Compare April 9, 2024 16:07
@dib542
Copy link
Collaborator Author

dib542 commented Apr 9, 2024

The UI tests are currently failing because the Swap page is hitting a Swap amount too small error and it cannot click the "Swap" button:

localhost_5173_swap_OSMO_NTRN(4_3)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy Previews

Testnet

Preview URL: https://67776af6-6423a894--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/661568703d949913da9b9349

Beta

Preview URL: https://67776af6-6423a894--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/661568bc57e508148a2e3ab9

@MrTalecky
Copy link
Collaborator

The falling UI test needs improvement, I'll fix that later.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy Previews

Testnet

Preview URL: https://283a0c40-b7ba4f89--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/661584490741ab155bd8aec4

Beta

Preview URL: https://283a0c40-b7ba4f89--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/661584970a2e5915cc6c6089

@dib542 dib542 merged commit 6139e1d into main Apr 9, 2024
2 checks passed
@dib542 dib542 deleted the 459-improve-buy-limit-orders-part-3 branch April 9, 2024 18:36
dib542 pushed a commit that referenced this pull request Apr 9, 2024
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
07ef511 
## [2.6.0](v2.5.0...v2.6.0) (2024-04-09)

### Features

* improve Orderbook UI and buy/sell orders ([#539](#539)) ([6139e1d](6139e1d)), closes [#537](#537) [#541](#541)
@dib542
Copy link
Collaborator Author

dib542 commented Apr 9, 2024

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dib542 dib542 added the released label Apr 9, 2024
This was referenced Apr 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy preview released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Buy Limit Orders
2 participants
@dib542 @MrTalecky