fix: 148 add current token price information #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the dependencies do not need to change size, the hook can be refactored
dib542
pushed a commit
that referenced
this pull request
Oct 19, 2022
## [0.1.32](v0.1.31...v0.1.32) (2022-10-19) ### Fixes * 148 add current token price information ([#157](#157)) ([b122ec3](b122ec3))
|
🎉 This PR is included in version 0.1.32 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes the incorrect workaround for exhaustive dependencies for React hooks:
// eslint-disable-next-line react-hooks/exhaustive-depsThe hooks have been redone (a little less efficiently as an extra
useMemois needed) in a way to keep the logic clear around creation of the varstokensandcachedResults. I thought to renamecachedResultsto justresultsbut this will cause a future merge conflict in the work for the My Liquidity page in #156 which is quite large at the moment.