Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: avoid static token list lookups #437

Merged
merged 9 commits into from
Sep 25, 2023
Merged

refactor: avoid static token list lookups #437

merged 9 commits into from
Sep 25, 2023

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Sep 24, 2023

This PR refactors current usage to avoid references to

  • addressableTokenMap
  • tokenListCache

As they are static lists and cannot easily contain IBC token info (which is fetched upon application load). The usage should instead use hooks that update with IBC info when that information is available.

@github-actions
Copy link

Preview URL: https://4609b3eb-c76b0620--duality-xyz.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz/deploys/651177ef5ed17f14a1610423

@github-actions
Copy link

Preview URL: https://efa68645-fa68cb29--duality-xyz.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz/deploys/65120d6f95c9ab0080502596

@dib542 dib542 merged commit e6a30d0 into main Sep 25, 2023
@dib542 dib542 deleted the 430-fix-ibc-token-usage-for-all-actions-part-1 branch September 25, 2023 23:00
@dib542 dib542 linked an issue Sep 25, 2023 that may be closed by this pull request
Fix: IBC token usage for all actions #430
Closed
dib542 pushed a commit that referenced this pull request Sep 26, 2023
@semantic-release-bot
chore(release): 0.3.16 [skip ci]
0931bfe 
## [0.3.16](v0.3.15...v0.3.16) (2023-09-26)

### Fixes

* ensure IBC tokens are referenced correctly ([#440](#440)) ([d6f7a67](d6f7a67))

### Other

* avoid static token list lookups ([#437](#437)) ([e6a30d0](e6a30d0))
* seperate denom amount getters ([#439](#439)) ([5fe9fc1](5fe9fc1))
@dib542
Copy link
Collaborator Author

dib542 commented Sep 26, 2023

🎉 This PR is included in version 0.3.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy preview released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: IBC token usage for all actions
1 participant
@dib542