fix: bridging functionality for testnet #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the requests can generate 404 Not Found responses if there is no
chain-registry IBC data between these chains
- the previous logic queried every connection, channel, and client
of an IBC chain, this was a lot of data for some real chains
- the new logic queries only the client state as the best check of
liveliness
- the previous check (now a suggested default check) did not
prevent error of a validator having incorrect account sequencing
- the error was: Error: Account '[account_number]' does not exist
on chain. Send some tokens there before trying to query sequence
dib542
force-pushed
the
523-fix-bridging-functionality-for-testnet
branch
from
0a23836 to
60afa2f
Compare
dib542
pushed a commit
that referenced
this pull request
Jan 30, 2024
## [2.0.1](v2.0.0...v2.0.1) (2024-01-30) ### Fixes * bridging functionality for testnet ([#524](#524)) ([1bb9f7b](1bb9f7b))
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Bridging functionality on the Bridge page of the tesnet app (https://app.testnet.duality.xyz/bridge)
Previously this was disabled, now it is enabled to Cosmos IBC enabled chains that have a direct connection listed in teh chain-registry IBC connections list, i.e. https://github.com/cosmos/chain-registry/tree/8e26c4b8fefc59a243e5239dceaed29b88519baa/testnets/_IBC
This PR also cleans up no longer used hooks after this fix (previous hooks used to fetch all connections/channels/clientStates have been removed as they generated many requests on some testnets).
The Bridging page also checks for:
To test
Current state
Expired channel/client:
Active channel/client:
Active channel/client mid-request:
