Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve buy limit orders #541

Closed
wants to merge 29 commits into from
Closed

fix: improve buy limit orders #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6e9dcb2
#537
dib542 Mar 14, 2024
579dabc
feat: remove trigger price, its not an option in finalized limit order
dib542 Mar 11, 2024
9274167
fix: remove "Unrecognized" option from input order types
dib542 Mar 6, 2024
95f403e
fix: protect against incorrect properties set in limit order
dib542 Mar 8, 2024
52de5fc
feat: allow string placeholder in LimitOrder number fields
dib542 Mar 6, 2024
cfe0976
fix: add buy limit orders with useSimulatedLimitOrderResult
dib542 Mar 12, 2024
8a320df
fix: disable form when no wallet is found
dib542 Mar 12, 2024
bd9dd84
feat: allow optional keep data behavior for simulation hook
dib542 Mar 14, 2024
c5b5497
reformat: use base and display versions of user balance
dib542 Mar 12, 2024
542c4af
feat: cap limit order simulation to available bank balance
dib542 Mar 12, 2024
63cef38
feat: add warning for sell amount too high
dib542 Mar 12, 2024
fbd45b9
feat: add warning for buy amount too high
dib542 Mar 12, 2024
20256ee
feat: add warning for insufficient liquidity
dib542 Mar 12, 2024
18062f3
fix: limit to supported order types
dib542 Mar 12, 2024
50f7ffb
fix: base amount display exponents can vary
dib542 Mar 12, 2024
1eb7c24
fix: add buy-simulation to find buy order range-slider amount out
dib542 Mar 12, 2024
549da2b
fix: set range slider fraction correctly in buy mode
dib542 Mar 12, 2024
5cebc5d
fix: sensitivity of max balance warnings for limit orders
dib542 Mar 12, 2024
c9eaf9b
fix: reduce warning length to avoid card width resizing
dib542 Mar 12, 2024
5f60de9
fix: calc input amounts from base denom values for correct rounding
dib542 Mar 13, 2024
dfc6e8c
fix: allow buy mode to set amountIn from range slider
dib542 Mar 13, 2024
c52540b
fix: make limit/liquidity warning checks work with new input
dib542 Mar 13, 2024
e991a98
feat: don't block orders from these warnings (they are imprecise)
dib542 Mar 13, 2024
a765ef0
feat: add current price into range slider value estimations
dib542 Mar 13, 2024
752c5f9
feat: unhide Orderbook from beta
dib542 Mar 13, 2024
ef799d6
fix: lessen duplicate msg simulations with more specific dependencies
dib542 Mar 13, 2024
f196799
feat: remove no longer used front-end router logic
dib542 Mar 14, 2024
069b70f
feat: make loading indicator follow state validation
dib542 Mar 14, 2024
df46b52
fix: limit price direction
dib542 Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.beta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ REACT_APP__CHAIN_PRETTY_NAME=Neutron

# App settings
REACT_APP__DEFAULT_PAIR=NEWT/NTRN
REACT_APP__HIDE_ORDERBOOK=1

# Chain data sources
REACT_APP__INDEXER_API=https://indexer.beta.duality.xyz
Expand Down
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"@chain-registry/client": "^1.18.0",
"@chain-registry/keplr": "^1.30.0",
"@chain-registry/utils": "^1.17.0",
"@cosmjs/amino": "0.31.1",
"@cosmjs/crypto": "0.31.1",
"@cosmjs/proto-signing": "0.31.1",
"@cosmjs/stargate": "0.31.1",
Expand Down
8 changes: 2 additions & 6 deletions src/components/Header/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
const { REACT_APP__DEFAULT_PAIR = '', REACT_APP__HIDE_ORDERBOOK = '' } =
import.meta.env;
const { REACT_APP__DEFAULT_PAIR = '' } = import.meta.env;

export const pageLinkMap = {
[['/swap', REACT_APP__DEFAULT_PAIR].join('/')]: 'Swap',
'/pools': 'Pools',
// conditionally add the orderbook in
...(!REACT_APP__HIDE_ORDERBOOK && {
[['/orderbook', REACT_APP__DEFAULT_PAIR].join('/')]: 'Orderbook',
}),
[['/orderbook', REACT_APP__DEFAULT_PAIR].join('/')]: 'Orderbook',
'/portfolio': 'Portfolio',
'/bridge': 'Bridge',
'https://duality.gitbook.io/duality-documentation/user-interface': 'Docs',
Expand Down
Loading
Loading