Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 85 update swap page logic to cosmjs usage #93
feat: 85 update swap page logic to cosmjs usage #93
Changes from 3 commits
91ea99b
b45d58f
0eb1317
27a8c07
4ecefac
0d8f101
1061c21
5561210
93aa822
4a74651
f0953b0
d835bf4
e1a93af
23cff23
e13d376
172de43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be limited by the
pagination.limit
. I noted this a little in https://github.com/duality-labz/duality-web-app/pull/89/files#diff-6229acd4cf5c56748b3fe173cff7f77469038a9815260bdb22f3551091b6b6e0R97-R103 though I didn't address it there, we could do something to be a little more explicit about limit, or do some recursive fetching here. (probably just note the limits for now)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I don't think we gain anything from having this function abstracted out here. It's only used once and its fairly specific. Is it out here for future tests? Its just making me go back and forth between line 42 and line 175 to read it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, just not sure what's the best way of implementing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can create another PR for it. I'd like to add a version of the code that I referenced, but that depends on the
queryClient
that is in #89. What i'd like to do is split off the usage of generated code from #89 into a separate PR that enhances this.