feat: 83 add cosmos service: add query and tx clients #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make all cosm.js dependencies 0.27.1
- no we only have 166 webpack warnings but no errors
- @cosmjs dependencies and the cosmjs-types dependency do not publish source code, so attempting to read the source code to generate maps will cause warnings
- other ways to deal with this:
- have a postinstall script to clone git source libraries into their needed destinations for source map generation to work correctly
- ignore specifically these errors in Webpack: "Failed to parse source map" & "Error: ENOENT: no such file or directory"
- this is difficult to do in create-react-app so perhaps it would be better to switch to a create-next-app or Vite build system
This reverts commit 3462564.
nickzoum
approved these changes
Jul 22, 2022
src/lib/web3/api.ts
Outdated
Comment on lines
62
to
70
| interface QueryClientOptions { | ||
| addr?: string; | ||
| } | ||
|
|
||
| const queryClient = async ({ | ||
| addr = REACT_APP__REST_API, | ||
| }: QueryClientOptions = {}) => { | ||
| return new Api({ baseUrl: addr }); | ||
| }; |
There was a problem hiding this comment.
This feels a bit too complicated
If we don't add any more attributes something like would be a lot simpler
Suggested change
| interface QueryClientOptions { | |
| addr?: string; | |
| } | |
| const queryClient = async ({ | |
| addr = REACT_APP__REST_API, | |
| }: QueryClientOptions = {}) => { | |
| return new Api({ baseUrl: addr }); | |
| }; | |
| const queryClient = (addr = REACT_APP__REST_API ) => { | |
| return new Api({ baseUrl: addr }); | |
| } |
If we do, I think somewhat spreading the defaults would make a more readable (maybe a tiny bit)
Suggested change
| interface QueryClientOptions { | |
| addr?: string; | |
| } | |
| const queryClient = async ({ | |
| addr = REACT_APP__REST_API, | |
| }: QueryClientOptions = {}) => { | |
| return new Api({ baseUrl: addr }); | |
| }; | |
| const defaultOptions = { | |
| addr: REACT_APP__REST_API | |
| }; | |
| const queryClient = (options = defaultOptions) => { | |
| const { addr } = { ...defaultOptions, ...options }; | |
| return new Api({ baseUrl: addr }); | |
| } |
There was a problem hiding this comment.
Resolved by pulling in the already generated ApiConfig type with the baseUrl already predefined in d1729a5
nickzoum
approved these changes
Jul 25, 2022
src/lib/web3/api.ts
Outdated
Comment on lines
65
to
71
| const queryClient = async ({ | ||
| baseUrl = REACT_APP__REST_API, | ||
| baseApiParams, | ||
| securityWorker, | ||
| }: ApiConfig = {}) => { | ||
| return new Api({ baseUrl, baseApiParams, securityWorker }); | ||
| }; |
There was a problem hiding this comment.
This isn't exactly the same, but I think you could just pass everything else as is, without having to care about the number of arguments being passed in
Suggested change
| const queryClient = async ({ | |
| baseUrl = REACT_APP__REST_API, | |
| baseApiParams, | |
| securityWorker, | |
| }: ApiConfig = {}) => { | |
| return new Api({ baseUrl, baseApiParams, securityWorker }); | |
| }; | |
| const queryClient = async (config: ApiConfig = {}) => { | |
| return new Api({ ...config, baseUrl: config?.baseUrl ?? REACT_APP__REST_API }); | |
| }; |
There was a problem hiding this comment.
good point, added a further simplification in 7f08a17
dib542
force-pushed
the
83-add-query-and-tx-clients
branch
from
f5f9b12 to
7f08a17
Compare
dib542
pushed a commit
that referenced
this pull request
Jul 25, 2022
## [0.1.8](v0.1.7...v0.1.8) (2022-07-25) ### Features * 83 add cosmos service: add query and tx clients ([#96](#96)) ([abafc31](abafc31))
|
🎉 This PR is included in version 0.1.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an autogenerated
queryClientand a semi-autogeneratedtxClientwith generated types from the Cosmos server, for easier using or queries and msgs from within components.