Allow saving coordinate trajectory on disk #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-young31 I am not quite sure how to implement the initialisation of the optimiser history file. Would be interested to hear if you think there are better ways to initialise the file interface. |
t-young31
reviewed
Mar 5, 2024
| return None | ||
|
|
||
| @staticmethod | ||
| def _coords_to_bytes(coords: OptCoordinates) -> bytes: |
There was a problem hiding this comment.
this is lots of effort. why not pickle?
There was a problem hiding this comment.
@t-young31 Pickling is said to be unsafe in the sense that it can run arbitrary code while unpickling. Given the feature of reading back an old saved trajectory from disk, it seems better to serialise manually. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist