read keepAlive to avoid useless warning: 'lease keepalive response qu… #115
Conversation
|
related issues: |
database/kv/etcd/v3/client.go
Outdated
| @@ -420,6 +420,12 @@ func (c *Client) keepAliveKV(k string, v string) error { | |||
| return perrors.New("keep alive lease") | |||
| } | |||
|
|
|||
| // read keepAlive to avoid useless warning: 'lease keepalive response queue is full; dropping response send' | |||
| go func() { | |||
There was a problem hiding this comment.
但是这样处理也太粗糙了吧？死循环？如果有更优雅的写法，可以改进下，没有那我明天给merge下
There was a problem hiding this comment.
已参考trillian 类似的方法处理: https://github.com/google/trillian/pull/2655/files
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 73.62% 73.62% -0.01%
==========================================
Files 51 51
Lines 4959 4970 +11
==========================================
+ Hits 3651 3659 +8
- Misses 1075 1078 +3
Partials 233 233
☔ View full report in Codecov by Sentry. |
…eue is full; dropping response send' Signed-off-by: DengXiewei <dengxiewei@eaglecloud.com>
|
代码已经合并，需要我打个版本吗? |
好的, 谢谢啦 |
read keepAlive to avoid useless warning logs, eg:
{"level":"warn","ts":"2023-10-09T21:15:11.243+0800","logger":"etcd-client","caller":"v3/lease.go:524","msg":"lease keepalive response queue is full; dropping response send","queue-size":16,"queue-capacity":16}
{"level":"warn","ts":"2023-10-09T21:15:11.243+0800","logger":"etcd-client","caller":"v3/lease.go:524","msg":"lease keepalive response queue is full; dropping response send","queue-size":16,"queue-capacity":16}
{"level":"warn","ts":"2023-10-09T21:15:21.253+0800","logger":"etcd-client","caller":"v3/lease.go:524","msg":"lease keepalive response queue is full; dropping response send","queue-size":16,"queue-capacity":16}
{"level":"warn","ts":"2023-10-09T21:15:21.253+0800","logger":"etcd-client","caller":"v3/lease.go:524","msg":"lease keepalive response queue is full; dropping response send","queue-size":16,"queue-capacity":16}
...