Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not add non-equal cap bytes back to pool #17

Merged
merged 1 commit into from
Dec 30, 2019
Merged

not add non-equal cap bytes back to pool #17

merged 1 commit into from
Dec 30, 2019

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Dec 30, 2019

What this PR does:
not add non-equal cap bytes back to pool

Special notes for your reviewer:
adding non-equal cap bytes back to pool will cause memory leak.

@wongoo
Copy link
Contributor Author

wongoo commented Dec 30, 2019

@micln pls review

@wongoo wongoo requested a review from micln December 30, 2019 01:43
micln
micln approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@micln micln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sorry

@micln
Copy link
Contributor

micln commented Dec 30, 2019

LGTM

@wongoo wongoo merged commit 3d7d91f into dubbogo:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micln micln micln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wongoo @micln