Make sure the webhook URL doesn't overflow the container #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the webhook card to use 'overflow-hidden' and 'truncate' for better URL handling. - Modified the webhook header to allow for line breaks in the URL display, enhancing readability. These changes enhance the user interface by ensuring that long URLs are displayed more effectively without breaking the layout.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steven-tey
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the layout and readability of webhook components in the user interface. The most important changes involve adding CSS classes to handle text overflow and prevent layout shifts.
Improvements to layout and readability:
apps/web/ui/webhooks/webhook-card.tsx: Addedflex-shrink-0class to prevent the avatar from shrinking andoverflow-hiddenclass to handle text overflow. Modified the URL display to use thetruncateclass for better text handling.apps/web/ui/webhooks/webhook-header.tsx: Addedbreak-allclass to the URL link to ensure long URLs break appropriately and do not overflow the container.