Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivate "compile" and "reload" (StackOverflowError) #209

Closed
dubreuia opened this issue Jan 20, 2019 · 9 comments
Closed

Deactivate "compile" and "reload" (StackOverflowError) #209

dubreuia opened this issue Jan 20, 2019 · 9 comments
Labels
bug
Milestone
1.8.0

Comments

@dubreuia
Copy link
Owner

  • "Compile" is still async (this breaks "reload")
  • "Compile" and "reload" should be exclusive
@dubreuia dubreuia added the bug label Jan 20, 2019
@dubreuia dubreuia modified the milestones: 1.4.0, 1.5.0 Jan 20, 2019
@dubreuia
Copy link
Owner Author

  • There's a double reload (first reload with nothing, then it gets compiled and the second reload is ok)

@dubreuia dubreuia removed this from the 1.5.0 milestone Mar 24, 2019
@dubreuia
Copy link
Owner Author

The compile action still triggers too much, see related issue.

@dubreuia
Copy link
Owner Author

"It triggers a recompilation 135 times on each triggering."

That might be a problem

@dubreuia dubreuia mentioned this issue Apr 19, 2019
Closed
@dubreuia dubreuia mentioned this issue Jun 3, 2019
Closed
@rcollette rcollette mentioned this issue Jun 20, 2019
Closed
This was referenced Jul 8, 2019
Closed
Closed
Closed
@dubreuia
Copy link
Owner Author

dubreuia commented Jul 8, 2019

Seeing how buggy this is, I'll just deactivate the feature

@dubreuia dubreuia changed the title Fix "compile" and "reload" Deactivate "compile" and "reload" Jul 8, 2019
@dubreuia dubreuia mentioned this issue Jul 8, 2019
Closed
@dubreuia dubreuia changed the title Deactivate "compile" and "reload" Deactivate "compile" and "reload" (StackOverflowError) Aug 12, 2019
@dubreuia dubreuia mentioned this issue Aug 12, 2019
Closed
@dubreuia dubreuia mentioned this issue Sep 9, 2019
Closed
@dubreuia dubreuia mentioned this issue Oct 10, 2019
Closed
@kangarko
Copy link

Let's talk money, we can pay you to fix this problem. Contact us at matej@mineacademy.org

@dubreuia
Copy link
Owner Author

Hello @kangarko, thank you for your offer, but I have a time problem, not a money problem. If I ever find time to do this, you'll be the first to know.

@kangarko
Copy link

Alright thanks!

@KotlinFactory KotlinFactory mentioned this issue Oct 22, 2019
Closed
@dubreuia dubreuia added this to the 1.8.0 milestone Dec 12, 2019
@dubreuia
Copy link
Owner Author

I'll release a fix in 1.8.0, based on the PR for #246. Tell me if that's what you had in mind @kangarko.

dubreuia added a commit that referenced this issue Dec 12, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
22836e5
dubreuia added a commit that referenced this issue Dec 12, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
f7080a8
dubreuia added a commit that referenced this issue Dec 12, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
0f0def7
dubreuia added a commit that referenced this issue Dec 13, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
102c311
dubreuia added a commit that referenced this issue Dec 13, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
f0f8ca0
dubreuia added a commit that referenced this issue Dec 13, 2019
@dubreuia
Fix #209: make reload and compile exclusive action
c27d315
@dubreuia
Copy link
Owner Author

Released in 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@dubreuia @kangarko