-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rider #310
Comments
This would be amazing. The only issue I've had with Rider is that I can't use a plugin like this. |
@van800 any chance you could issue a PR with that workaround you mentioned in the other issue so this will work on Rider? It's definitely a huge missing gap that we don't have format on save on Rider. Thanks! |
I've just tested in Rider, the plugin is called, the reformat is called, but nothing happens.
|
That would probably be due to the research I did earlier... See #18 (comment). |
I completely forgot about that discussion we had. There is also #198 |
I just tried that but it seems to only actually format the currently focused file |
Oh no I was almost ready to push the fix. I've disabled the reformat buttons for Rider with a message. Maybe I can use |
That's awesome. The plugin also does not currently show up on the marketplace for Rider, could you include it once this is fixed? |
Yes, if I can make it work... I'll add it to the marketplace. |
I can't make it work. I've also tried with the "Code Cleanup" action, either it doesn't work, or it only works on 1 file, or it pops up a dialog. EDIT: see code in https://github.com/dubreuia/intellij-plugin-save-actions/tree/issue_310_support_rider |
Did you try using the "Silent Code Cleanup" option? The user would have to set which option to use for silent code cleanup though. |
Yes @giuliano-barberi-tf, unfortunately it doesn't work (works only for the current file). |
I, too, am interested in this for Rider. I made a small script to run rclone to make a more permanent local history style file backup but would like some additional options over just the file watcher. |
I'm releasing a partial fix in 2.1.0, it might work for the current file. Please let me know if it does |
I've tested 2.1.0 in Rider (2020.2.2) using a Quick List with just the "Reformat Code" action.
BTW: Awesome plugin! I enjoy using it in WebStorm and would love to have it in Rider as well. |
Hey @sgaertner thank you so much for testing. I would also love to see the plugin work in Rider, but I'll have to debug more how the formatter works. |
I'd also love to see this plugin to work in Rider. 😁 |
Not working for me either, instalation from disk Reformat Code |
See #18 : Rider (settings OK - reformat KO)
The text was updated successfully, but these errors were encountered: