Fix: Unable to shrink mapped command

dubzzz · Dec 15, 2018 · 21864f3 · 21864f3
1 parent f9f6f41
commit 21864f3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/check/model/commands/CommandsArbitrary.ts b/src/check/model/commands/CommandsArbitrary.ts
@@ -56,7 +56,7 @@ class CommandsArbitrary<Model extends object, Real, RunResult> extends Arbitrary
     return emptyOrNil
       .join(size.shrink().map(l => items.slice(0, l.value).concat(items[items.length - 1]))) // try: remove items except the last one
       .join(this.shrinkImpl(items.slice(0, items.length - 1), false).map(vs => vs.concat(items[items.length - 1]))) // try: keep last, shrink remaining (rec)
-      .join(items[0].shrink().map(v => [v].concat(items.slice(1)))); // try: shrink first, keep others
+      .join(items[items.length - 1].shrink().map(v => items.slice(0, -1).concat([v]))); // try: shrink last, keep others
   }
 }
 

diff --git a/test/e2e/model/CommandsArbitrary.spec.ts b/test/e2e/model/CommandsArbitrary.spec.ts
@@ -70,13 +70,7 @@ describe(`CommandsArbitrary (seed: ${seed})`, () => {
       const cmdsRepr = out.counterexample![0].toString();
       const m = /check\[(\d+)\]$/.exec(cmdsRepr);
       assert.notEqual(m, null, `Expected to end by a check[..] command, got: ${cmdsRepr}`);
-
-      const limit = +m![1];
-      const expectedRepr = `${[...Array(limit)].map(_ => 'inc').join(',')},check[${limit}]`;
-      assert.equal(cmdsRepr, expectedRepr);
-
-      // TODO: Use this expect instead
-      // assert.equal(cmdsRepr, 'inc,check[1]', `Expected the only played command to be 'inc,check[1]', got: ${cmdsRepr}`);
+      assert.equal(cmdsRepr, 'inc,check[1]', `Expected the only played command to be 'inc,check[1]', got: ${cmdsRepr}`);
     });
     it('Should result in empty commands if failures happen after the run', () => {
       const out = fc.check(