Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧(worker) Migrate jest to esm #4604

Merged
merged 11 commits into from
Jan 21, 2024
Merged

🔧(worker) Migrate jest to esm #4604

merged 11 commits into from
Jan 21, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 6, 2024

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Copy link

codesandbox-ci bot commented Jan 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc2ba9d:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) January 21, 2024 16:35
@dubzzz
Copy link
Owner Author

dubzzz commented Jan 21, 2024

I now have some "A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them." popping in the logs of the run. It was not the case before the switch.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a81e26) 93.57% compared to head (dc2ba9d) 93.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4604   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files         207      207           
  Lines        5011     5011           
  Branches     1367     1367           
=======================================
  Hits         4689     4689           
  Misses        322      322           
Flag Coverage Δ
unit-tests 93.57% <ø> (ø)
unit-tests-18.x-Linux 93.57% <ø> (ø)
unit-tests-20.x-Linux 93.57% <ø> (ø)
unit-tests-latest-Linux 93.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit c5e4340 into main Jan 21, 2024
53 checks passed
@dubzzz dubzzz deleted the worker-jest-es branch January 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant