Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘· Move website build chain to ESM #4649

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

πŸ‘· Move website build chain to ESM #4649

wants to merge 7 commits into from

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 22, 2024

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21242ca:

Sandbox Source
@fast-check/examples Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 22, 2024

Failing at Run yarn workspace website build with:

[INFO] [en] Creating an optimized production build...
[info] [webpackbar] Compiling Client
[info] [webpackbar] Compiling Server
[success] [webpackbar] Client: Compiled successfully in 23.58s
[success] [webpackbar] Server: Compiled with some errors in 25.16s

Error: Unable to build website for locale en.

    at tryToBuildLocale (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/commands/build.js:55:19)
[INFO] Docusaurus version: 3.1.0
Node version: v20.11.0
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async mapAsyncSequential (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-utils-virtual-462f6e933a/4/.yarn/berry/cache/@docusaurus-utils-npm-3.1.0-987dffbfde-10c0.zip/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
    at async Command.build (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/commands/build.js:82:21) {
  [cause]: Error: Failed to compile due to Webpack errors.
  TypeError: require.resolveWeak is not a function
      at /home/runner/work/fast-check/fast-check/.yarn/__virtual__/@docusaurus-core-virtual-1a479300b6/4/.yarn/berry/cache/@docusaurus-core-npm-3.1.0-e2c1849322-10c0.zip/node_modules/@docusaurus/core/lib/webpack/utils.js:207:24
      at /home/runner/work/fast-check/fast-check/.yarn/__virtual__/webpack-virtual-056dc0b43c/4/.yarn/berry/cache/webpack-npm-5.89.0-3800e9efd0-10c0.zip/node_modules/webpack/lib/MultiCompiler.js:554:14
      at processQueueWorker (/home/runner/work/fast-check/fast-check/.yarn/__virtual__/webpack-virtual-056dc0b43c/4/.yarn/berry/cache/webpack-npm-5.89.0-3800e9efd0-10c0.zip/node_modules/webpack/lib/MultiCompiler.js:491:6)
      at process.processTicksAndRejections (node:internal/process/task_queues:77:11)

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 94.49%. Comparing base (e5cb7af) to head (7721e7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4649   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files         212      212           
  Lines        9623     9623           
  Branches     2671     2670    -1     
=======================================
  Hits         9093     9093           
  Misses        530      530           
Flag Coverage Ξ”
unit-tests 94.49% <ΓΈ> (ΓΈ)
unit-tests-18.x-Linux 94.49% <ΓΈ> (ΓΈ)
unit-tests-20.x-Linux 94.49% <ΓΈ> (ΓΈ)
unit-tests-22.x-Linux 94.49% <ΓΈ> (ΓΈ)
unit-tests-latest-Linux 94.49% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 30, 2024

The issue seems similar to the one detailed at facebook/docusaurus#6520 (comment)

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 22, 2024
@dubzzz dubzzz removed the stale label Apr 25, 2024
Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 1, 2025
@dubzzz dubzzz removed the stale label Feb 1, 2025
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 7721e7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 10, 2025

Open in Stackblitz β€’ @fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@4649

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@4649

fast-check

npm i https://pkg.pr.new/fast-check@4649

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@4649

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@4649

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@4649

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@4649

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@4649

commit: 7721e7a

@dubzzz dubzzz enabled auto-merge (squash) February 10, 2025 20:59
@dubzzz
Copy link
Owner Author

dubzzz commented Feb 18, 2025

Probably worth migrating away from webpack. PR should be easy after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant