support path-as-is #387
Closed
support path-as-is #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not support the "./" path. This implementation differs from httpie and curl. 
|
zuisong
commented
Oct 30, 2024
src/cli.rs
Outdated
| .map(|it| it.1) | ||
| .unwrap_or(url_string); | ||
| let path = after_scheme.split_once('/').unwrap().1; | ||
| let mut url = Url::from_file_path(format!("/{}", path)).unwrap(); |
There was a problem hiding this comment.
Special handling is required for the Windows system.
|
The effect cannot be achieved like curl or xh, so it has been temporarily disabled. |
|
Interesting (and too bad you can't make it work). Hyper uses a reqwest issue: seanmonstar/reqwest#2396 |
|
Indeed, this is quite sad. This implementation currently does not work on the Windows platform and does not support "./" paths. This feature can only be implemented after changes are made upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clever method to avoid URL normalization. see epi052/feroxbuster#878 (comment)
Here's a cheeky way to implement
path-as-is.