Use static OpenSSL for tests #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just remembered coming across this thread sagebind/isahc#68 (comment) which recommends using |
|
Aha, that looks even better. Gives us less C code to compile. |
|
Apparently it still depends on OpenSSL if you enable the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl-rustturns out to have a feature for building with a bundled statically linked OpenSSL. That solves some of the problems we had in #75.The integration tests don't work on ARM, possibly because of some QEMU limitation. So I've gated those behind a default feature. The other tests do work.