Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on macOS and Windows #111

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Run tests on macOS and Windows #111

merged 5 commits into from
Oct 3, 2023

Conversation

fpoli
Copy link
Contributor

@fpoli fpoli commented Aug 7, 2023

This PR tests duchess on Windows and macOS as part of the CI.

For simplicity, mdBook test is still only executed on Ubuntu. To have something cross-platform for mdbook it might be better to use some published GitHub action.

Note that I upgraded the ui_test dependency from version 0.10 to 0.15. Since ui_test 0.15 uses recently stabilized Rust features, users might have to do a rustup update before compiling duchess.

@fpoli fpoli force-pushed the test-other-os branch 2 times, most recently from 4f49b41 to 8fae3b2 Compare August 8, 2023 12:30
@fpoli fpoli requested a review from a team August 8, 2023 12:32
@fpoli fpoli removed the request for review from a team August 24, 2023 08:31
@nikomatsakis
Copy link
Member

@fpoli maybe disable windows for now?

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@fpoli fpoli added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 85c5bad Oct 3, 2023
@fpoli fpoli deleted the test-other-os branch October 5, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants