Fix #368: display only attach path in connection error message, instead of the full DSN that is used to connect #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of the full DSN that is used to connect
2 tasks
staticlibs
added a commit
to staticlibs/duckdb-mysql
that referenced
this pull request
Nov 11, 2025
This change is a counterpart of the duckdb/duckdb-postgres#383 change. Testing: new test added that checks error message, existing URI test is is disabled because the attach path is now diplayed in unparsed form.
staticlibs
added a commit
to duckdb/duckdb-mysql
that referenced
this pull request
Nov 13, 2025
This change is a counterpart of the duckdb/duckdb-postgres#383 change. Testing: new test added that checks error message, existing URI test is is disabled because the attach path is now diplayed in unparsed form.
arnfred
added a commit
to GowerStreet/metabase_duckdb_driver
that referenced
this pull request
Dec 11, 2025
I'm updating duckdb to version 1.4.3 to avoid postgres secrets being leaked by duckdb and metabase when connecting to postgres through duckdb in metabase. See this issue for more context: duckdb/duckdb-postgres#368 See this PR for the fix: duckdb/duckdb-postgres#383 This fix was picked up in Duckdb 1.4.2
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368