Bump to duckdb v1.4.2 and plug DuckDB own logging #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PostgresQueryLogDUCKDB_LOGs, logging query (or queries) and duration in msSecond step, that is passing around
ClientContext &contextchanging a lot of signatures I am less sure, it can probably be reworked, open to feedback.All in all, this allows for example:
Here we are attaching to a ducklake backed by Postgres, and run some queries.
This could allowing a faster feedback cycle: directly from SQL, debug what interactions (and how much latency they bring) are required on the underlying Postgres database. This allows both users to tweak / understand how heavy are certain queries, and developers to get feedback and optimize them.