Skip to content

Fix ADBC driver path resolution when importlib.util was not implicitly loaded #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Fix ADBC driver path resolution when importlib.util was not implicitly loaded #135

merged 1 commit into from
Oct 28, 2025

Conversation

@henryharbeck
Copy link

@henryharbeck henryharbeck commented Oct 20, 2025

Fixes #134

Also removes a print statement when the driver is found.

@evertlammerts evertlammerts changed the base branch from main to v1.4-andium October 27, 2025 13:31
@evertlammerts evertlammerts changed the base branch from v1.4-andium to main October 27, 2025 13:32
@evertlammerts
Copy link
Collaborator

evertlammerts commented Oct 27, 2025

Thanks @henryharbeck, looks good to me. Can you rebase this onto the v1.4-andium branch? That way it can make it into 1.4.2.

@henryharbeck henryharbeck changed the base branch from main to v1.4-andium October 28, 2025 11:07
@henryharbeck henryharbeck changed the base branch from v1.4-andium to main October 28, 2025 11:12
@henryharbeck henryharbeck changed the base branch from main to v1.4-andium October 28, 2025 12:00
@henryharbeck henryharbeck reopened this Oct 28, 2025
@henryharbeck
Copy link
Author

henryharbeck commented Oct 28, 2025

Thanks, done

evertlammerts
evertlammerts approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@evertlammerts evertlammerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@evertlammerts evertlammerts added this pull request to the merge queue Oct 28, 2025
Merged via the queue into duckdb:v1.4-andium with commit 50c802b Oct 28, 2025
6 checks passed
@henryharbeck henryharbeck mentioned this pull request Nov 2, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evertlammerts evertlammerts evertlammerts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't connect to ADBC Driver if importlib.util is not implicitly loaded

2 participants

@henryharbeck @evertlammerts