feat: data frame with lazy relation AltrepDataFrameRelation
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Jan 7, 2025
src/relational.cpp
Outdated
| projections.push_back(std::move(dexpr)); | ||
| } | ||
|
|
||
| duckdb::rel_extptr_t rel = cpp11::as_cpp<cpp11::decay_t<duckdb::rel_extptr_t>>(rapi_rel_from_df(con, df, false)); |
There was a problem hiding this comment.
The rapi_() functions are external, this coupling is a bit too tight. Perhaps extract an internal function?
krlmlr
reviewed
Jan 7, 2025
| @@ -162,6 +162,28 @@ using namespace cpp11; | |||
| return make_external_prot<RelationWrapper>("duckdb_relation", prot, res); | |||
| } | |||
|
|
|||
| [[cpp11::register]] SEXP rapi_rel_filter2(data_frame df, duckdb::conn_eptr_t con, list exprs) { | |||
There was a problem hiding this comment.
Can we move these to a separate .cpp file and keep them in the same order as here?
There was a problem hiding this comment.
This is still valid. Can you please follow up?
|
I like the idea of |
krlmlr
reviewed
Jan 8, 2025
| } | ||
|
|
||
| const vector<ColumnDefinition> &AltrepDataFrameRelation::Columns() { | ||
| return columns; |
There was a problem hiding this comment.
Why this change? Can this still be parent->...() ?
krlmlr
reviewed
Jan 8, 2025
| } | ||
| duckdb::rel_extptr_t rel = cpp11::as_cpp<cpp11::decay_t<duckdb::rel_extptr_t>>(rapi_rel_from_any_df(con, df, true)); | ||
|
|
||
| auto filter = make_shared_ptr<FilterRelation>(rel->rel, std::move(filter_expr)); |
There was a problem hiding this comment.
This should be wrapped in an ALTREP data frame at this stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #949