-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial support of table function #112
Conversation
Change-Id: Iee9e36ce944390ea7477316f3576adcd7118cf54
CI failed because of documentation Some notes about next steps:
|
@wangfenjin we're working on a rust implementation of lance data format and would be interested in seeing if your PR here can provide an easy way for us to write a Lance Scanner (comes out as Arrow) + replacement scan function (so basically item 3 in your next steps). Are you planning to substantially change the API here? |
Change-Id: I123228378fd7747b9fc4dee3993bed3b11cd553b
Change-Id: I0fa1758d9e2a40b0daaf37fc3887998d7d72e534
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 59.47% 58.36% -1.12%
==========================================
Files 26 28 +2
Lines 1483 1638 +155
==========================================
+ Hits 882 956 +74
- Misses 601 682 +81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Change-Id: Ic2f0ada2edea4aa2073224bbb8a5a1c0b56a8c81
Change-Id: I77aca28125c255ebfdf97c5a8ef05bae7014b459
in favor of #138 |
This is based on @Mause 's https://github.com/Mause/duckdb-extension-framework
It works (refer test_table_function), but I'm thinking about design a more safe and high level API, similiar to rusqlite vtab, So need more time to merge the MR
If anyone interested to work on this base on this version can let me know
related to #102 #79