Upgrade duckdb to 0.9.2 and update dependencies #240
Conversation
src/raw_statement.rs
Outdated
| arrow2::error::Error::OutOfSpec(_) => return None, | ||
| _ => panic!("Failed to import arrow2 Array from C: {}", err), | ||
| } | ||
| panic!("Failed to import arrow2 Array from C: {}", err) |
There was a problem hiding this comment.
Not positive, but I don't believe this is valid comment anymore. It looks like This is incorrect let me see if I can sort it out since they aren't using the old error anymore.polars did some housekeeping in the last couple of months with their polars-arrow package. It looks like the relevant bits are here.
An aside I stumbled on this issue with some additional information on the changes:
jorgecarleitao/arrow2#1476
There was a problem hiding this comment.
Sorted it out, they're using PolarsError::ComputeError now
|
Thanks for the PR. Would be great to get this in (plus #238 maybe 😎) and cut a new release. 🙏 |
|
@mlafeldt Since it moved under duckdb I'm not sure who has approval and release access. @wangfenjin Sorry to ping you, but are you still the best person to reach out to for PRs or is there someone under the DuckDB org that's taken over? Thank you again for starting this project 🙏 |
|
Thanks for the contribution. I no longer have the write permission for this repo, I’m sure someone will handle the PR |
|
Asked about code ownership in Discord. |
|
Thanks! LGTM |
Hi @wangfenjin, sorry about that, that was a mistake on my end. You should have write permissions and I now restored them. |
Running the upgrade script; also updated bindgen, arrow, and polars. Let me know if I should roll any dependency updates back.