fix: appender crash #296
Merged
fix: appender crash #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures that the pointer is correctly cleared when errors occur
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287