Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch all bindings #1546

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Patch all bindings #1546

merged 2 commits into from
Jan 2, 2024

Conversation

Y--
Copy link
Contributor

@Y-- Y-- commented Dec 22, 2023

Now that node is an Emscripten environment, we need to patch all JS bindings to be able to run ESbuild bundling with DuckDB WASM build with loadable extension mode.

Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mytherin Mytherin merged commit 8957eda into duckdb:main Jan 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants