-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string passing at interface C++ to JS #1905
Conversation
8d15ff6
to
dda7bde
Compare
dda7bde
to
feb1aba
Compare
Should |
Yes, thanks. I will address those in a separate PR, I think this still makes sense as-is. |
Separate PR is fine. But note that |
Less important for us, but also needing attention, is |
This is minor, but a couple of the C functions have unused "script" arguments:
|
Follow up is here: #1906 |
Thanks to @jraymakers that identified the problem.
There are still a few places where we pass table names or DB names, those ought to be shorter, but I will address and remove those in a separate PR, for now keeping old and new interface in, but using only the new one where we pass only malloc-ed memory around.