-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quantile_cont/disc ORDER BY support #11419
Comments
Sorry, battling features. We should not be injecting the missing arguments when they are not missing... Incidentally I hope to get to windowed versions with independent sorting axes after 1.0. |
The PERCENTILE_XXX rewrite was colliding with the sorted aggregate rewrite here. Also cleaned up the quantile negation logic to not have scary holes... fixes: duckdb#11419 fixes: duckdblabs/duckdb-internal#1712
Great to hear that's on your radar. Am I justified to be optimistic that this will bring a positive resolution to #11425 eventually as well? |
Also, sorry to hijack this even more, but since you seem to be the window expert: do you think there is any hope for #10703? |
The PERCENTILE_XXX rewrite was colliding with the sorted aggregate rewrite here. Also cleaned up the quantile negation logic to not have scary holes... fixes: duckdb#11419 fixes: duckdblabs/duckdb-internal#1712
What happens?
quantile_cont
andquantile_disc
doesn't currently support ordering, so that the ugly SQL standardWITHIN GROUP
aggregates are required whenquantile_cont(column, q ORDER BY column DESC)
is desired.Additionally, it is not currently possible even with the
WITHIN GROUP
aggregates, to achievequantile_disc(column, q ORDER BY other_column)
(which seems nonsensical at first, but is perfectly well-defined and useful, I promise.)To Reproduce
OS:
Linux
DuckDB Version:
0.10.2
DuckDB Client:
Python
Full Name:
Soeren Wolfers
Affiliation:
G-Research
Have you tried this on the latest nightly build?
I have tested with a nightly build
Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
The text was updated successfully, but these errors were encountered: