Move duckdb specifics from workflow to Makefile #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
force-pushed
the
abstract_duckdb
branch
from
1b5c5d3
to
46fe8f1
Compare
samansmink
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is make room for other kind of extensions that might not have such a strict dependency / need for the duckdb submodule.
This is mostly connected to C-API extensions, but possibly also other ways of handling dependencies or other use cases can also become relevant.
Currently there are no changes that actually would allow a C-API extension, but I think overriding
set_duckdb_version,set_duckdb_tagandoutput_distribution_matrixto no-op, no-op and returning a default might work fine.